-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: implement milestones #961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into vaibhav/POS-609
…ibhav/POS-609 Pull from the develop branch
…lestoneNoReorg Pull from develop
Vaibhav/milestone iteration1
…/bor into vaibhav/Milestone-2
VAIBHAVJINDAL3012
changed the base branch from
vaibhav/Milestone
to
vaibhav/MilestoneIteration1
August 16, 2023 14:27
Pull merge develop
temaniarpit27
changed the base branch from
vaibhav/MilestoneIteration1
to
develop
August 24, 2023 07:13
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #961 +/- ##
===========================================
- Coverage 57.02% 56.89% -0.13%
===========================================
Files 633 638 +5
Lines 77326 77855 +529
===========================================
+ Hits 44096 44297 +201
- Misses 29460 29779 +319
- Partials 3770 3779 +9
☔ View full report in Codecov by Sentry. |
manav2401
approved these changes
Aug 25, 2023
VAIBHAVJINDAL3012
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement milestones - PIP-11
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it