Protobuf tooling fix and upgrade #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vcastellm
commented
Jan 24, 2022
- Paths for protobuf files has changed, reflect that in Makefile
- Fix the tooling to make it work in macos
- Update protoc version and regenarate files.
POS-134 Cleanup protobuf install script for Mac users
Currently, the protobuf script only works for linux users since it downloads the linux binary. Change this to detect if the user is using Mac (most of our developers) and download the other binary. https://github.com/maticnetwork/bor/blob/master/scripts/tools-protobuf.sh#L4 |
added 2 commits
January 25, 2022 18:03
* Paths for protobuf files has changed, reflect that in Makefile * Fix the tooling to make it work in macos * Update protoc version and regenarate files.
0b34003 to
6aecebd
Compare
|
Should we close this @ferranbt? |
ssandeep
approved these changes
Jan 26, 2022
ferranbt
approved these changes
Jan 28, 2022
vcastellm
added a commit
that referenced
this pull request
May 9, 2022
* Protobuf tooling fix and upgrade * Paths for protobuf files has changed, reflect that in Makefile * Fix the tooling to make it work in macos * Update protoc version and regenarate files. * Regen proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.