Configure bor params in the unit itself #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssandeep
reviewed
Dec 17, 2021
ssandeep
previously approved these changes
Dec 23, 2021
added 5 commits
January 5, 2022 08:43
This PR removes the necessity of having a startup script, less moving parts, and less files to watch.
As we are going to embed genesys data into the binary, this is the most close method to do it before the new CLI. This way, each release gets tied to it's corresponding genesys file. This establish bor repository as the source of truth for the genesys file.
0acd850 to
39e7fb0
Compare
ferranbt
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes the necessity of having a startup script and an almost empty environment
metadatafile, less moving parts, and less files to watch.Implementation
As we are going to embed genesis data into the binary, this is the most similar method to do it before the new CLI release.
This way, each release gets tied to its corresponding genesis file.
This establish
borrepository as the source of truth for the genesis file.