jaipur fork #269
Merged
jaipur fork #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POS-102 Encoding baseFee when calculating headerSignature
Tenderly reported this:
|
ferranbt
suggested changes
Dec 14, 2021
jdkanani
suggested changes
Dec 14, 2021
jdkanani
suggested changes
Dec 15, 2021
ferranbt
reviewed
Dec 15, 2021
ssandeep
approved these changes
Dec 15, 2021
ferranbt
approved these changes
Dec 15, 2021
| @@ -111,6 +112,14 @@ func buildNextBlock(t *testing.T, _bor *bor.Bor, chain *core.BlockChain, block * | |||
| copy(header.Extra[32:], validatorBytes) | |||
| } | |||
|
|
|||
| if chain.Config().IsLondon(header.Number) { | |||
There was a problem hiding this comment.
Why wasn't this here before? Did the test worked without this? Was it necessary and was running fine?
vcastellm
pushed a commit
that referenced
this pull request
Jan 11, 2022
* jaipur fork * add check * review comments * test case * fix few changes * Change condition * review comments * type conversion * Update mumbai.go * Update config.go * Update config.go Co-authored-by: Ferran Borreguero <ferranbt@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.