Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and improve documentation across several files #1381

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

Dimitrolito
Copy link
Contributor

This PR addresses several typographical issues across multiple documentation files. The changes include fixing hyphenation errors, correcting article usage, and updating duplicated phrases.

Changes

  • Fixed the spelling of "password-protected" in intapi_changelog.md.
  • Corrected the use of "an" vs. "a" in server.md and README.md for consistency and clarity.
  • Added missing hyphen in "cross-origin" in server.md.
  • Removed duplicated phrase "to have" in rules.md.

Checklist

  • I have added at least 2 reviewers or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have manually tested the changes in my local environment.
  • I have tested the functionality in the remote devnet.

Additional comments

No additional comments.

@marcello33
Copy link
Contributor

Thanks @Dimitrolito
Can you change the target branch to develop?

@Dimitrolito Dimitrolito changed the base branch from master to develop December 10, 2024 11:07
@Dimitrolito
Copy link
Contributor Author

@marcello33
Done! I have changed the target branch to 'develop' as requested

@marcello33 marcello33 requested a review from a team December 11, 2024 12:10
@marcello33 marcello33 merged commit 135878f into maticnetwork:develop Dec 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants