Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis amoy json #1208

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Genesis amoy json #1208

merged 1 commit into from
Apr 8, 2024

Conversation

anshalshukla
Copy link
Contributor

Description

Adds amoy genesis in json format, external requirement communicated by support team

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@anshalshukla anshalshukla changed the base branch from master to v1.3.0-beta-candidate April 4, 2024 08:19
@anshalshukla anshalshukla requested a review from 0xsharma April 4, 2024 08:19
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.44%. Comparing base (fd4b9c2) to head (f40abf9).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           v1.3.0-beta-candidate    #1208      +/-   ##
=========================================================
- Coverage                  51.44%   51.44%   -0.01%     
=========================================================
  Files                        794      794              
  Lines                     131304   131304              
=========================================================
- Hits                       67549    67547       -2     
- Misses                     59576    59580       +4     
+ Partials                    4179     4177       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshalshukla anshalshukla merged commit 7ae6dec into v1.3.0-beta-candidate Apr 8, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants