Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload milestones audit #1200

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Upload milestones audit #1200

merged 1 commit into from
Mar 26, 2024

Conversation

marcello33
Copy link
Contributor

Description

Upload milestones audit pdf.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

@marcello33 marcello33 requested a review from a team March 25, 2024 15:56
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.43%. Comparing base (8be2283) to head (3782ca1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1200   +/-   ##
========================================
  Coverage    51.42%   51.43%           
========================================
  Files          794      794           
  Lines       131308   131308           
========================================
+ Hits         67530    67538    +8     
+ Misses       59594    59589    -5     
+ Partials      4184     4181    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 merged commit df47eb9 into develop Mar 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants