Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: fix GetTransactionReceiptsByBlock method #1085

Merged
merged 2 commits into from
Dec 12, 2023
Merged

internal/ethapi: fix GetTransactionReceiptsByBlock method #1085

merged 2 commits into from
Dec 12, 2023

Conversation

bbaktaeho
Copy link
Contributor

Description

effectiveGasPrice is missing in the Receipt of the GetTransactionRecipetsByBlock method.
Also, the initialization type of log is invalid.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Hi, I'm currently implementing a Polygon Indexer. I'm using bor client and I found an error in that method. I hope it's reflected quickly.

@pratikspatil024 pratikspatil024 requested a review from a team November 17, 2023 03:31
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (3c97a5b) 56.01% compared to head (18c8802) 56.01%.
Report is 4 commits behind head on develop.

Files Patch % Lines
internal/cli/flagset/flagset.go 0.00% 14 Missing ⚠️
internal/ethapi/api.go 0.00% 6 Missing ⚠️
params/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1085   +/-   ##
========================================
  Coverage    56.01%   56.01%           
========================================
  Files          658      658           
  Lines       114437   114440    +3     
========================================
+ Hits         64098    64102    +4     
+ Misses       46492    46485    -7     
- Partials      3847     3853    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33
Copy link
Contributor

Thanks for spotting this @bbaktaeho
Can you fix the linter?

@bbaktaeho bbaktaeho requested a review from marcello33 November 17, 2023 10:36
@0xKrishna 0xKrishna requested a review from a team November 22, 2023 06:40
@temaniarpit27 temaniarpit27 requested a review from a team November 30, 2023 06:33
@leo-lambda256
Copy link

@marcello33 Please request approval from other reviewers.

@temaniarpit27 temaniarpit27 merged commit 2be2789 into maticnetwork:develop Dec 12, 2023
12 of 13 checks passed
Woodpile37 added a commit to Woodpile37/bor that referenced this pull request Jan 10, 2024
@Woodpile37
Squashed commit of the following:
702e23d 
commit dac4c40
Author: Vaibhav Jindal <vaibhavjindal29@gmail.com>
Date:   Mon Dec 18 15:38:12 2023 +0530

    Removed the check for milestoneID in the GetVoteOnHash()

commit 8b2f024
Author: Pratik Patil <pratikspatil024@gmail.com>
Date:   Fri Dec 15 12:49:11 2023 +0530

    test all default flags added via config file (maticnetwork#1105)

commit 2be2789
Merge: db5b398 18c8802
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Tue Dec 12 10:57:53 2023 +0530

    Merge pull request maticnetwork#1085 from bbaktaeho/fix/eth_api

    internal/ethapi: fix GetTransactionReceiptsByBlock method

commit db5b398
Author: marcello33 <marcelloardizzone@hotmail.it>
Date:   Fri Dec 8 06:56:23 2023 +0100

    Update matic-cli in CI (maticnetwork#1103)

commit abab36b
Merge: 1065e21 073d75c
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Wed Dec 6 10:46:55 2023 +0530

    Merge pull request maticnetwork#1098 from maticnetwork/arpit/fix-shadowfork

    allow unprotected txns

commit 073d75c
Merge: 4e3e1de 9682679
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Sun Dec 3 17:17:30 2023 +0530

    Merge branch 'arpit/fix-shadowfork' of github.com:maticnetwork/bor into arpit/fix-shadowfork

commit 4e3e1de
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Sun Dec 3 17:16:37 2023 +0530

    added log

commit 9682679
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Sun Dec 3 17:14:57 2023 +0530

    Update core/txpool/validation.go

    Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com>

commit 1065e21
Author: Anshal Shukla <53994948+anshalshukla@users.noreply.github.com>
Date:   Fri Dec 1 11:39:58 2023 +0530

    consensus/bor: handle blockalloc balance changes (maticnetwork#1074)

    * fix: set balance in blockalloc

    * chg: don't update balance if not zero

    * fix: lint

    * fix logic, add test cases

commit 91ff270
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Thu Nov 30 15:35:46 2023 +0530

    allow unprotected txns

commit 18c8802
Author: bbaktaeho <bbaktaeho@gmail.com>
Date:   Fri Nov 17 19:34:50 2023 +0900

    fix: lint

commit 7714cd8
Author: bbaktaeho <bbaktaeho@gmail.com>
Date:   Thu Nov 16 23:04:53 2023 +0900

    fix GetTransactionReceiptsByBlock
@bbaktaeho bbaktaeho mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcello33 marcello33 marcello33 approved these changes

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bbaktaeho @marcello33 @leo-lambda256 @temaniarpit27 @eliasdiek