-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve bor server --help
#1063
Merged
manav2401
merged 11 commits into
maticnetwork:develop
from
leovct:leovct/chore-update-txarrivalwait-flag-description
Nov 7, 2023
Merged
chore: improve bor server --help
#1063
manav2401
merged 11 commits into
maticnetwork:develop
from
leovct:leovct/chore-update-txarrivalwait-flag-description
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
changed the title
chore: update
chore: remove redundant defaults from Oct 26, 2023
txarrivalwait
flag descriptionbor server
flags description
leovct
changed the title
chore: remove redundant defaults from
chore: improve Oct 26, 2023
bor server
flags descriptionbor server --help
Codecov ReportAttention:
... and 21 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
pratikspatil024
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
manav2401
approved these changes
Nov 7, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bor server --help
.This is before the fix.
This is after the fix.
make docs
. I've seen that docs haven't been updated since a long time, I can make a follow-up PR with a CI job if you guys want :)Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it