Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placement of surd when root extends above the horizontal line (mathjax/MathJax#2764) #743

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix placement of surd when root extends above the horizontal line (mathjax/MathJax#2764) #743

merged 1 commit into from
Feb 22, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 15, 2021

This PR fixes a problem in SVG output for mroot when the height of the root extends above that of the surd itself, as in

\sqrt[\frac{1}{2}]{1}

In that case, the root symbol was too high. This PR positions it correctly.

Resolves issue mathjax/MathJax#2764.

@dpvc dpvc requested a review from zorkow September 15, 2021 21:40
zorkow
zorkow approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works (at least in the lab and Brave). lgtm.

@dpvc dpvc merged commit 6700bd5 into develop Feb 22, 2022
@dpvc dpvc deleted the issue2764 branch February 22, 2022 13:27
@dpvc dpvc added this to the 3.2.1 milestone Feb 22, 2022
@dpvc dpvc mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow