Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build tools to make it easier to create custom components #592

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 23, 2021

This PR adjusts the component building tools to make it easier to create custom components (like tex extensions) outside of the MathJax-src/components directory. The main changes are in the webpack.common.js file, and allow for better control over the libraries that are linked. It also now supports imports like

import {MathItem} from 'mathjax-full/js/core/MathItem';

where mathjax-full will be found in node_modules, and the .js is omitted. (Our v3-lab doesn't handle that, but node and webpack do, so it is useful to allow it.)

Most of the other changes are to make the output easier to read (more directory prefix collapsing, and separate indicators for MathJax's components and js code as compared to local components and local js code).

@dpvc dpvc requested a review from zorkow February 23, 2021 19:56
@dpvc dpvc added this to the 3.1.3 milestone Feb 23, 2021
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Base automatically changed from fix-pack to develop March 8, 2021 19:44
@dpvc dpvc merged commit 9bd1ae3 into develop Mar 8, 2021
@dpvc dpvc deleted the improve-build-tools branch March 8, 2021 19:48
@dpvc dpvc changed the title Improve build tools to make it earlier create custom components Improve build tools to make it easier to create custom components Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants