Fix issue with textmacros in SVG mode. (mathjax/MathJax#2524) #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
For some reason I could not reproduce the reported error, so I can only assume that is the right fix.
It looks exactly the same for me in both develop and issue2524 branch (or when pulling tex-svg-full from the cdn for that matter).
[And just to be precise, I was testing with Firefox (79.0) on Win10.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where inferred mrows were being improperly included in the contexts of
text{}when mathematics is also within the text. This issue affected SVG output primarily. The fix is to convert the inferred mrow into a real mrow.Resolves issue mathjax/MathJax#2524.