Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ids from assistive MathML to avoid duplicates #525

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 9, 2020

This PR resolves a problem with the assistive MathML. If there are IDs in the MathML (e.g., from \tag or \cssId macros, or explicit tags in MathML input), those IDs will appear in the CHTML or SVG output, but also in the hidden MathML from the assitive-mml extension. Here, we subclass the SerilaizeMmlVisitor to remove them in the hidden MathML.

See this post for the original complaint.

@dpvc dpvc requested a review from zorkow July 9, 2020 19:20
@dpvc dpvc added this to the v3.1.0 milestone Jul 9, 2020
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants