Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mi2mo action #392

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Remove mi2mo action #392

merged 2 commits into from
Dec 16, 2019

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Nov 18, 2019

Remove the mi2mo() action for munderover and related constructs (since a TeX input post-filter now handles non-mo elements that have movable limits). In addition, it fixes a problem where an explicitly set texClass could be lost if lspace or rspace was set (this was the case with mi2mo(), but now that that is removed). This was a cause for some test failures from mathjax/MathJax-dev#30. But these changes will require additional update to those tests, since the mi are no longer changed to mo.

Finally, it also adds missing jsdoc comments to one function.

…er now handles non-mo elements with movable limits)
@dpvc dpvc requested a review from zorkow November 18, 2019 01:11
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo. O/w lgtm.
I will fix the tests once it is merged.

ts/input/tex/ParseUtil.ts Outdated Show resolved Hide resolved
@dpvc dpvc merged commit f945b0d into develop Dec 16, 2019
@dpvc dpvc deleted the no-mi2mo branch December 16, 2019 19:28
@dpvc dpvc added this to the 3.0.1 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants