Handle self-closing tags in liteDOM. #328 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
requested changes
Nov 17, 2019
| @@ -211,7 +211,7 @@ export class LiteParser implements MinDOMParser<LiteDocument> { | |||
| // Otherwise, the child tag becames the parent node to which | |||
| @@ -189,7 +189,7 @@ export class LiteParser implements MinDOMParser<LiteDocument> { | |||
| // | |||
| // Get the child to be added to the node | |||
| // | |||
| const kind = tag.match(/<(.*?)[\s\n>]/)[1].toLowerCase(); | |||
| const kind = tag.match(/<(.*?)[\s\n>/]/)[1].toLowerCase(); | |||
There was a problem hiding this comment.
Should that not be
Suggested change
| const kind = tag.match(/<(.*?)[\s\n>/]/)[1].toLowerCase(); | |
| const kind = tag.match(/<(.*?)[\s\n/>]/)[1].toLowerCase(); |
?
There was a problem hiding this comment.
The order of the characters in the [...] doesn't matter. It just matches up to any one of the enclosed characters. So it is correct as is.
There was a problem hiding this comment.
Right. I now realise that it is only any of the four characters.
zorkow
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the liteDOM to handle self-closing tags (in particular, for MathML that has things like
<mspace width="1em" />or<mrow/>).Resolves issue #328