Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lints new issues #1163

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Lints new issues #1163

merged 3 commits into from
Nov 18, 2024

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Nov 15, 2024

PR does three things:

  • Lints a few issues that have been introduced during the latest PR merges
  • Adds the linting rule to prefer includes over indexOf for array membership test, as discussed f2f
  • Adds mandatory linting for every commit. Note,
    • this means that commit will fail if there are lint errors, but not when there are only warnings
    • it also adds a bit of extra time when committing. If this is annoying we can take it out again.

@zorkow zorkow requested a review from dpvc November 15, 2024 15:44
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dpvc dpvc added this to the v4.0 milestone Nov 15, 2024
@zorkow zorkow merged commit bbdf640 into develop Nov 18, 2024
@zorkow zorkow deleted the linting/new_issues branch November 18, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants