Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactors and simplifies macro mappings #1096

Merged
merged 4 commits into from
Jun 27, 2024
Merged

refactors and simplifies macro mappings #1096

merged 4 commits into from
Jun 27, 2024

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented May 30, 2024

  • Refactors macro, command and environment maps in the packages to directly use methods provided by the MacroMap classes. This
    1. makes our code less dependant on string references
    2. should allow bundlers that minimize code (like Closure) to more efficiently replace method calls
  • Retains legacy functionality by keeping an optional functionMap argument and checking if the ParseMethod reference is a string. This should ensure backward compatibility with third party packages.

Base automatically changed from refactor/namespaces to develop June 4, 2024 13:01
@dpvc dpvc added this to the v4.0 milestone Jun 5, 2024
@zorkow zorkow marked this pull request as ready for review June 10, 2024 21:08
@zorkow zorkow requested a review from dpvc June 10, 2024 21:08
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@zorkow zorkow merged commit dedbde8 into develop Jun 27, 2024
@zorkow zorkow deleted the refactor/mappings branch June 27, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants