-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/35 #36
base: master
Are you sure you want to change the base?
Bug/35 #36
Conversation
aa3ca60
to
a7b779d
Compare
@mathisonian is it ok that i upgraded the node versions that get tested? |
node 10 seems to be the lowest supported version with my changes. can someone confirm if/how #35 affects windows and mac? can't check on mac. |
so i played around a bit and i think this false positive can not corrur on windows 🤔 |
Hi @rbbl-dev. Thanks for the PR. I'm okay dropping support for the older versions of node - we should update the docs & package.json to reflect this as well. It also looks like there are some files added that don't need to be included (the |
sure thing. can you test on osx? |
done goofed 😆 |
@mathisonian i would be ready with that PR |
Hey @rbbl-dev sorry for the slowness, I can test on a mac this week. |
no worries. i know how life can be :) |
Any updates on this? It seems like this is still not fixed. |
aims to fix #35