Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/35 #36

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Bug/35 #36

wants to merge 13 commits into from

Conversation

rbbl-dev
Copy link

aims to fix #35

@rbbl-dev rbbl-dev force-pushed the bug/35 branch 2 times, most recently from aa3ca60 to a7b779d Compare March 28, 2022 21:29
@rbbl-dev
Copy link
Author

@mathisonian is it ok that i upgraded the node versions that get tested?
4 to 9 seems a bit too old given that their docker only reaches back to 12

@rbbl-dev
Copy link
Author

node 10 seems to be the lowest supported version with my changes.

can someone confirm if/how #35 affects windows and mac?

can't check on mac.
windows will take me some time.

@rbbl-dev
Copy link
Author

rbbl-dev commented Mar 28, 2022

so i played around a bit and i think this false positive can not corrur on windows 🤔

@mathisonian
Copy link
Owner

Hi @rbbl-dev. Thanks for the PR. I'm okay dropping support for the older versions of node - we should update the docs & package.json to reflect this as well. It also looks like there are some files added that don't need to be included (the .idea folder). Could you add that to .gitignore?

@rbbl-dev
Copy link
Author

rbbl-dev commented Mar 29, 2022

It also looks like there are some files added that don't need to be included (the .idea folder). Could you add that to .gitignore?

sure thing.

can you test on osx?

@rbbl-dev
Copy link
Author

rbbl-dev commented Mar 30, 2022

the issue on windows seems to be that where is not available on powershell and powershell to be the default windows console.

done goofed 😆

@rbbl-dev
Copy link
Author

rbbl-dev commented Apr 3, 2022

@mathisonian i would be ready with that PR

@mathisonian
Copy link
Owner

Hey @rbbl-dev sorry for the slowness, I can test on a mac this week.

@rbbl-dev
Copy link
Author

no worries. i know how life can be :)

@haerter-tss
Copy link

Any updates on this? It seems like this is still not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive if there is a folder with the same name as the command in question
3 participants