Skip to content

Commit

Permalink
Add tests for Array.prototype.sort stability
Browse files Browse the repository at this point in the history
  • Loading branch information
mathiasbynens committed Nov 30, 2018
1 parent 45e98f7 commit 490292d
Show file tree
Hide file tree
Showing 3 changed files with 612 additions and 0 deletions.
37 changes: 37 additions & 0 deletions test/built-ins/Array/prototype/sort/stability-11-elements.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Copyright (C) 2018 Mathias Bynens. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-array.prototype.sort
description: >
Stability of Array.prototype.sort for an array with 11 elements.
info: |
The sort is required to be stable (that is, elements that compare equal
remain in their original order).
The array length of 11 was chosen because V8 used an unstable
QuickSort for arrays with more than 10 elements until v7.0 (September
2018). https://v8.dev/blog/array-sort
---*/

const array = [
{ name: 'A', rating: 2 },
{ name: 'B', rating: 3 },
{ name: 'C', rating: 2 },
{ name: 'D', rating: 4 },
{ name: 'E', rating: 3 },
{ name: 'F', rating: 3 },
{ name: 'G', rating: 4 },
{ name: 'H', rating: 3 },
{ name: 'I', rating: 2 },
{ name: 'J', rating: 2 },
{ name: 'K', rating: 2 },
];
assert.sameValue(array.length, 11);

// Sort the elements by `rating` in descending order.
// (This updates `array` in place.)
array.sort((a, b) => b.rating - a.rating);

const reduced = array.reduce((acc, element) => acc + element.name, '');
const isProbablyStable = reduced === 'DGBEFHACIJK';
assert(isProbablyStable);
28 changes: 28 additions & 0 deletions test/built-ins/Array/prototype/sort/stability-5-elements.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// Copyright (C) 2018 Mathias Bynens. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-array.prototype.sort
description: >
Stability of Array.prototype.sort for an array with 5 elements.
info: |
The sort is required to be stable (that is, elements that compare equal
remain in their original order).
---*/

const array = [
{ name: 'A', rating: 2 },
{ name: 'B', rating: 3 },
{ name: 'C', rating: 2 },
{ name: 'D', rating: 3 },
{ name: 'E', rating: 3 },
];
assert.sameValue(array.length, 5);

// Sort the elements by `rating` in descending order.
// (This updates `array` in place.)
array.sort((a, b) => b.rating - a.rating);

const reduced = array.reduce((acc, element) => acc + element.name, '');
const isProbablyStable = reduced === 'BDEAC';
assert(isProbablyStable);
Loading

0 comments on commit 490292d

Please sign in to comment.