Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug print statements in tests + bump GH action versions #523

Merged
merged 1 commit into from
Jan 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
if: github.repository_owner == 'materialsproject' && github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'push' && startsWith(github.event.workflow_run.head_branch, 'v0.')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.event.workflow_run.head_branch }}

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand All @@ -35,7 +35,7 @@ jobs:
needs:
- deploy-pypi
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.event.workflow_run.head_branch }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/joss-pdf.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
on:
push:
paths:
- paper
- paper
workflow_dispatch:

jobs:
Expand All @@ -10,7 +10,7 @@ jobs:
name: Paper Draft
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Build draft PDF
uses: openjournals/openjournals-draft-action@master
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.9'
cache: pip
Expand All @@ -38,9 +38,9 @@ jobs:
python-version: ['3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: pip
Expand All @@ -67,12 +67,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install pandoc
run: sudo apt-get install pandoc

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.11'
cache: pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
auto-update:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v3
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ default_language_version:
exclude: "^src/atomate2/vasp/schemas/calc_types/"
repos:
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.1.9
rev: v0.1.11
hooks:
- id: ruff
args: [--fix]
Expand Down
7 changes: 6 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,16 @@ select = [
]
ignore = [
"B028",
"COM812",
"DTZ005",
"FBT001",
"FBT002",
"PLR0911", # too-many-return-statements
"PLR0912", # too-many-branches
"PLR0913", # too-many-arguments
"PLR0915", # too-many-statements
"PLW0603",
"PTH",
"RUF013",
]
pydocstyle.convention = "numpy"
Expand All @@ -169,4 +174,4 @@ isort.known-first-party = ["jobflow"]
# D: pydocstyle
# PLR2004: magic-value-comparison
# PT004: pytest-missing-fixture-name-underscore
"**/tests/*" = ["D", "PLR2004", "PT004"]
"**/tests/*" = ["ANN", "ARG001", "D", "PLR2004", "PT004", "S101"]
1 change: 0 additions & 1 deletion tests/core/test_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ def detour_job():
test_job = Job(addition_job, config=pass_config)
response = test_job.run(memory_jobstore)
assert len(response.addition) == 1
print(response.addition)
assert response.addition[0].config.manager_config == manager_config
assert response.addition[0].hosts == [response.addition.uuid]

Expand Down
1 change: 0 additions & 1 deletion tests/managers/test_fireworks.py
Original file line number Diff line number Diff line change
Expand Up @@ -658,5 +658,4 @@ def test_external_reference(lpad, mongo_jobstore, fw_dir, simple_job, capsys):

# check response
result2 = mongo_jobstore.query_one({"uuid": uuid2})
print(result2)
assert result2["output"] == "12345_end_end"
Loading