Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect #1056

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Defect #1056

merged 1 commit into from
Jul 19, 2024

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Jul 19, 2024

Defect Document Model

Added document model for defect task documents.

  • Inherits from TaskDoc
  • Maybe allow Locpot reference but should be kept separately: DefectTaskDoc:locpot should contain just a reference to the data.
  • Basic test for parsing.

Make ChgcarDataDoc inherit from VolumetricDataDoc

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (0fde16f) to head (b878539).

Files Patch % Lines
emmet-core/emmet/core/defect.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   88.68%   88.74%   +0.05%     
==========================================
  Files         113      114       +1     
  Lines       10307    10340      +33     
==========================================
+ Hits         9141     9176      +35     
+ Misses       1166     1164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

added defect

added defect

tests

tests

dep

dep

typo

remove extra

change key

added volumetric

refactor

not optional

not optional

removed potcar
@munrojm munrojm merged commit 36ea77e into materialsproject:main Jul 19, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants