Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update prettier icon #2904

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rowan-walsh
Copy link
Contributor

Description

Update Prettier icon to display better at standard resolution: previously the shapes were all smaller than a pixel at 16x16 which led to it blurring out.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Feb 23, 2025
Copy link
Contributor

github-actions bot commented Feb 23, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief requested a review from lucas-labs February 24, 2025 07:45
Copy link
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

The only problem I can see is that it's a bit hard to see in light themes. But the same is happening already with the original icon.

We could try using a slightly darker palette and see how it goes.

e.g.:

  • #00897B instead of #4DB6AC
  • #BA68C8 instead of #CE93D8
  • ...etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants