-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(form-field): Add support for space-between #5754
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! We'll pull it in to do some more testing, but this looks good to me :)
@asyncLiz thanks for the help and for the tips! |
One final round of reviews to go, getting close :) |
@asyncLiz ok, I think it is ready. Waiting for your review :) |
Co-Authored-By: Liz Mitchell <asyncliz@gmail.com>
done :) |
Co-Authored-By: Liz Mitchell <asyncliz@gmail.com>
Co-Authored-By: Liz Mitchell <asyncliz@gmail.com>
@asyncLiz I wasn't aware IE11 is supported :/ |
No worries! That's my fault for suggesting the |
Glad I could help 🙂 |
Hm our bots are going a little bit crazy. Everything worked, except copybara created a new PR at #5759 and merged that instead of this one... 🤦♀️ Not entirely sure how that happened, but the change is in master now. I'll close this and comment on the other PR to refer to this one for the history. |
For MWC, feel free to go ahead and open a PR to get the process started. Hopefully it'll be a little smoother. |
@asyncLiz I've tried adding this to MWC, but I got stuck on setup. I work on Windows 10 machine and I can't run any npm scripts. The issue was reported here: material-components/material-web#459. |
Sure thing, should be a trivial thing to add |
@asyncLiz thank you. |
No worries. I went ahead and implemented it because I knew I'd need to do some work anyway to get screenshot tests up to date. It'd also have been faster than the windows bug, which was lower priority 😊 |
This PR adds
![image](https://user-images.githubusercontent.com/1741838/77768710-23904a80-7043-11ea-9c44-8febdc8e0430.png)
mdc-form-field--space-between
class.fixes: #5747
This allows easily creating this layout:
https://jsfiddle.net/Misiu/quzgcsev/25/
Sample code:
I've added support for
mdc-form-field--align-end
, but I'm not sure how support for RTL languages should look.Also, this is my first PR in this repo, so sorry for any mistakes.