-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RN 0.71.0 #4
Conversation
@mateioprea please merge this PR ASAP |
Sorry, but your PR doesn't work on older versions of RN. You can test it with the example app. Do you want to fix these issues? |
|
@mateioprea I'm not good at native code, maybe major upgrade will do the thing and have a division for pre 0.71 react and post? That's what is usually done to resolve backward incompatibility especially there were no changes to the lib for a year. |
I don't believe it's trivial to support 71 as well as prior RN versions, as most libs do you should note in the readme which versions support which RN version.
|
I can confirm that a lot of libs that support RN 71 have dropped support for older versions. I'd bump the major version and drop a deprecation warning. Users can still use a lower version when they need support for < 0.71 imho. |
@hirbod exactly. |
@hirbod and that means that unless I’m using new arch, I won’t be able to get latest updates? |
No, @mateioprea, when you follow the PR like done in react-native-mmkv, or this open PR (which does base on the mmkv one) mrousavy/react-native-blob-jsi-helper#11 - your library will still work on Paper, but it requires RN 0.71. The template and the build steps got much better and faster with 0.71 and supporting older versions is just tedious work. |
Sorry, but this doesn't work for me. I get this error: I don't know if its me or the new implementation, but i won't release this until i can run it successfully. |
Found the issue. I'm gonna release this later today. |
@mmmoussa @jahglow released under v2.0.0: https://www.npmjs.com/package/react-native-random-values-jsi-helper. Thank you for your contributions! 🥇 |
This PR is based on mrousavy/react-native-mmkv#480 and mrousavy/react-native-mmkv#499. Tested it in my own app and confirmed it's working. Closes #3.