Implement tab views #386
Merged
Implement tab views #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Love it! Thanks so much for your contribution. I'd like to get 2.5 shipped as it already contains several improvements and bug fixes. This will be properly reviewed and merged asap after it. If you didn't see already, the live demo looks fantastic https://deploy-preview-386--learn.netlify.com/en/shortcodes/tabs/ |
PrasadG193
added a commit
to kubeshop/botkube-docs
that referenced
this pull request
Apr 25, 2020
Changes are taken from: matcornic/hugo-theme-learn#386 Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
added a commit
to kubeshop/botkube-docs
that referenced
this pull request
Apr 27, 2020
Changes are taken from: matcornic/hugo-theme-learn#386 Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193
added a commit
to kubeshop/botkube-docs
that referenced
this pull request
Apr 27, 2020
Changes are taken from: matcornic/hugo-theme-learn#386 Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
|
Just tried this out locally using hugo v0.74.3, but it wasn't working. It seems this bug was fixed by #403. |
|
Any update on this? Would be great to have in the Hugo Learn Theme :) |
|
Same here, can this be merged or is there anything still pending? |
Closed
|
This is awesome and just what I needed to reduce page lengths. What's the normal time frames for PR inclusion into the learn theme? |
This was referenced Mar 17, 2021
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
otherwise we are not able to tab thru search results on the search page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently decided to add this to our internal documentation. I thought other people might find it useful, too.
I do speak some French but I'd still leave the translation up to someone else.
closes #70
Btw. the code was inspired by solutions from:
https://github.com/gohugoio/hugoDocs/
https://github.com/kubernetes/website/
https://www.mediaevent.de/tutorial/css-tabs.html