Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in latest Mermaid JS - 8.2.6 #327

Closed
wants to merge 4 commits into from

Conversation

simonwfarrow
Copy link

Hi,

I have pulled down the latest mermaid release from here
This has dropped the CSS files, so I have removed those.
I have also added a new parameter called mermaidTheme which allows you to set which theme to use as per this breaking change

@simonwfarrow simonwfarrow mentioned this pull request Sep 10, 2019
@aazon
Copy link

aazon commented Mar 6, 2020

Are there any reasons not to merge this pull request?

@mirisbowring
Copy link
Contributor

mirisbowring commented Mar 6, 2020

@aazon this solution is not best practice in my opinion, because it does not exactly solve the problem (see #361 #362).

@mbbx6spp
Copy link
Contributor

mbbx6spp commented Sep 7, 2020

See #443 for later upgrade.

@mirisbowring
Copy link
Contributor

But why should this implementation be better than the CDN method?
You're must download mermaid from CDN to use it - so even your version is from the mermaid CDN.

In 2-3 Weeks your version is outdated and has to be updated manually via a new PR.

BTW, Git is not made for handling framework's (each upgrade, your repo is growing by some Megabytes) - That is why node was invented (besides many other reasons).

@matalo33
Copy link
Contributor

Thank you for the submission, and apologies for not looking at it sooner. This change is now superseded by #443

@matalo33 matalo33 closed this Sep 10, 2020
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants