Allow more than 1 worker per thread pool set by set-thread-affinity #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
reviewed
Sep 4, 2024
av1an-core/src/broker.rs
Outdated
| @@ -109,18 +109,10 @@ impl<'a> Broker<'a> { | |||
|
|
|||
| cfg_if! { | |||
| if #[cfg(any(target_os = "linux", target_os = "windows"))] { | |||
| let available_threads = available_parallelism().expect("Unrecoverable: Failed to get thread count").get(); | |||
There was a problem hiding this comment.
Maybe move this to the second #[cfg]-gated block. If it's here, this will always panic on any linux/windows platform that does not support available_parallelism or for any OS user without the necessary permissions on Linux.
If you move it down, it won't call available_parallelism unless the user sets a non-zero thread affinity.
There was a problem hiding this comment.
Yes, I fully agree.
I changed the commit.
And also trimmed the code in the process, as well as making other minor improvements...
FreezyLemon
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.