Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BISECTED] Accsess violation on vapoursynth input #773

Closed
Quackdoc opened this issue Jul 11, 2023 · 1 comment
Closed

[BISECTED] Accsess violation on vapoursynth input #773

Quackdoc opened this issue Jul 11, 2023 · 1 comment

Comments

@Quackdoc
Copy link

Quackdoc commented Jul 11, 2023

commit 330e6a2 (bisected and manually tested the previous commit to verify it worked) introduced a regression for one user that causes av1an to be killed by svchost due to accsess violation we narrowed it down to LN 910 let frame_rate = self.input.frame_rate().unwrap(); by manually adding a before and after check to this.

av1an isnt providing a backtrace even when compiled we needed to use GFLAGS from windbg since the process was silently exiting.

it regulairly manages to go through about at least 200 loops before dying. the footage is CFR. tested enforcing it inside of the VS script too with no luck.

still trying to help a user debug it but this is what we have for now, I haven't been able to replicate the issue myself even with the same footage. verified the install environment is the same with VS and same av1an binary.

EDIT: I checked the windows dumps and it looks like this is actually an intermittent vapoursynth crash on the users end. more testing will be done but if nothing else shows up in the next few days ill end up closing this ticket as a VS issue

@Quackdoc
Copy link
Author

Another user is reporting this crashes during the check framerate step and likewise VS itself is segfaulting on windows

shssoichiro added a commit that referenced this issue Jul 16, 2023
This may mitigate #773, further testing is required to verify.
Overall it should slightly improve performance as well.
shssoichiro added a commit that referenced this issue Jul 16, 2023
This may mitigate #773, further testing is required to verify.
Overall it should slightly improve performance as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants