Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-9854: Update babelify dependency #113

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

rbayliss
Copy link
Member

@rbayliss rbayliss commented Aug 1, 2018

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

This is a followup to the security update(#75) to update a dependency that was a little too complicated to handle in the scope of the update ticket. This PR updates babelify, which required adding the babel-core and babel-preset-env packages. Babel will now build javascript based on our .browserlistrc file (same as our SCSS).

Related Issue / Ticket

Steps to Test

  1. Using multiple browsers, find javascript heavy pages in Mayflower and try them out. Some examples:
    • Location listing pages
    • Event listing pages
    • Etc..
  2. Make sure all javascript functionality matches what's currently on https://mayflower.digital.mass.gov/.

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

@rbayliss rbayliss requested a review from mrossi113 August 1, 2018 22:06
Copy link
Contributor

@mrossi113 mrossi113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Tested the location listing and event listing pages in multiple browsers: Firefox ESR, Firefox 61, Chrome 67, and IE 11.

@mrossi113 mrossi113 requested a review from ygannett August 2, 2018 14:49
Copy link
Contributor

@ygannett ygannett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge.

@ygannett ygannett merged commit 49252d4 into develop Aug 2, 2018
@avrilpearl avrilpearl deleted the patternlab/DP-9854-update-babelify branch October 9, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants