Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming onboarding guide, adding credential guide #84

Merged
merged 18 commits into from
Sep 5, 2024
Merged

Renaming onboarding guide, adding credential guide #84

merged 18 commits into from
Sep 5, 2024

Conversation

mclacore
Copy link
Contributor

@mclacore mclacore commented Aug 27, 2024 •
edited
Loading

This is a big guide. Lots of stuff going on. I had a lot of fun playing around w/ React to get this to work. Might be overkill, might not be. But I think it's cool.

@linear Linear
Copy link

linear bot commented Aug 27, 2024

ORC-576 Add credential section to Getting Started

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 10:29pm

@mclacore mclacore marked this pull request as ready for review August 28, 2024 19:31
@mclacore mclacore requested a review from chrisghill August 28, 2024 19:32
chrisghill
chrisghill approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@chrisghill chrisghill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this mostly copy-pasta'd from the website?

@mclacore
Copy link
Contributor Author

Is this mostly copy-pasta'd from the website?

Yes. With context edits, spell fixes, and updates.

wasinsandiego
wasinsandiego approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@wasinsandiego wasinsandiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rad! I dropped a suggestion in slack to make reusable components for the input and display the input's value. Let me know if you have any questions or comments.

@mclacore
Big refactor changes
5804a0d 
* Refactored CredentialInput -> DisplayDocInput, DocInput,
DocInputProvider
* Cleaned up language, added screenshot, cleaned up flow
* Updates to markdown based on refactoring
* Added default value for aws role/azure service principal/gcp service
account (massdriver-provisioner)
@mclacore mclacore merged commit b9ef8f9 into main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasinsandiego wasinsandiego wasinsandiego approved these changes

@xpositivityx xpositivityx xpositivityx approved these changes

@chrisghill chrisghill chrisghill approved these changes

@coryodaniel coryodaniel Awaiting requested review from coryodaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mclacore @coryodaniel @wasinsandiego @xpositivityx @chrisghill