Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more data on the transfers traces #4655

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Feb 28, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT AurelienFT requested a review from sydhds February 28, 2024 10:40
@AurelienFT AurelienFT enabled auto-merge February 28, 2024 10:55
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.78%. Comparing base (d1b371c) to head (8057ee0).

Files Patch % Lines
massa-execution-worker/src/execution.rs 54.54% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4655   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienFT AurelienFT added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit a2d15b0 Feb 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants