Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeroize on Wallet struct #4624

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Zeroize on Wallet struct #4624

merged 1 commit into from
Jan 12, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jan 11, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from bilboquet and damip January 11, 2024 16:08
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dbac57) 71.78% compared to head (6234602) 71.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4624   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damip damip added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 96db852 Jan 12, 2024
@sydhds sydhds deleted the feature/zeroize_wallet branch January 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants