Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrap retry #3576

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Fix bootstrap retry #3576

merged 6 commits into from
Feb 16, 2023

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Feb 15, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT
Copy link
Contributor Author

Fix #3412

@AurelienFT
Copy link
Contributor Author

Tried to make a bootstrap test but it's too complicated and takes too much time. Will test it in labnet with modified node.

@AurelienFT AurelienFT marked this pull request as ready for review February 16, 2023 01:00
@AurelienFT AurelienFT requested a review from Eitu33 February 16, 2023 01:00
@AurelienFT
Copy link
Contributor Author

I have tested on labnet with tests line of 31e2e60 this allow to make the first bootstrap fail and wait so much that the second fail for too old slot and after reset everything went well and the final hash at slot was good

Eitu33
Eitu33 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Eitu33 Eitu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an open issue about the possibility of retrying bootstrap from the downloaded state of a previously failed bootstrap or is that not something we want to handle?

@AurelienFT
Copy link
Contributor Author

Do we have an open issue about the possibility of retrying bootstrap from the downloaded state of a previously failed bootstrap or is that not something we want to handle?

It should already be possible if it's not a too old slot. For a too old slot I don't think it's possible

@AurelienFT AurelienFT merged commit 114bead into testnet_20 Feb 16, 2023
@AurelienFT AurelienFT mentioned this pull request Feb 16, 2023
Closed
@AurelienFT AurelienFT mentioned this pull request Feb 27, 2023
Merged
bors bot added a commit that referenced this pull request Mar 1, 2023
@bors @AurelienFT
@Ben-PH @modship @Eitu33 @sydhds @aoudiamoncef
Merge #3489
f01d16a 
3489: Testnet 20 r=AurelienFT a=AurelienFT

Merged in this testnet:

- #3475 
- #3549
- #3562 
- #3462 
- #3492 
- #3502 
- #3495 
- #3556 
- #3511 
- #3498 
- #3566 
- #3557 
- #3576 
- #3579 
- #3507 
- #3585 
- #3587 
- #3580 
- #3590 
- #3549 
- #3455 
- #3601 
- #3602 
- #3606 
- #3588 
- #3603 
- #3554

Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Co-authored-by: Ben PHL <benphawke@gmail.com>
Co-authored-by: Modship <yeskinokay@gmail.com>
Co-authored-by: Ben <benphawke@gmail.com>
Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: modship <lu@massa.net>
Co-authored-by: Moncef AOUDIA <22281426+aoudiamoncef@users.noreply.github.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
Closed
28 tasks
@AurelienFT AurelienFT deleted the fix_bootstrap_retry branch May 29, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @Eitu33