Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lazy error handling in get_block_slot_timestamp #3473

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add lazy error handling in get_block_slot_timestamp #3473

merged 1 commit into from
Jan 27, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Jan 26, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@aoudiamoncef
Copy link
Contributor Author

I checked the entire codebase to find similar code, so this the only function affected.

AurelienFT
AurelienFT approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gas costs is broken today you can still merge it. Will be fixed ASAP

@aoudiamoncef aoudiamoncef merged commit 0fbf2b8 into testnet_19 Jan 27, 2023
@AurelienFT AurelienFT deleted the feature/small-imps branch May 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aoudiamoncef @AurelienFT