Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind to IPv6 addr. #3463

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Jan 24, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Only binding on IPv6 addresses (bind_private = "[::]:33034", bind_public = "[::]:33035" and bind_api = "[::]:33036") still works with IPv4 only interfaces.

Cf issue #2607

@Leo-Besancon Leo-Besancon requested a review from sydhds January 24, 2023 08:48
@Leo-Besancon Leo-Besancon marked this pull request as draft January 24, 2023 10:17
@Leo-Besancon
Copy link
Collaborator Author

Postman queries went through, however the current solution breaks the client.
I'll investigate more.

@Leo-Besancon Leo-Besancon marked this pull request as ready for review January 24, 2023 11:23
Copy link
Contributor

@sydhds sydhds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good idea to make ipv6 the default? I'm wondering if it can confuse user. Maybe documentation about supported ip address (ipv4 + ipv6) can help?

@Leo-Besancon
Copy link
Collaborator Author

Is this a good idea to make ipv6 the default? I'm wondering if it can confuse user. Maybe documentation about supported ip address (ipv4 + ipv6) can help?

Oh, you mean a user that knows what 127.0.0.1 means but only sees ip = "::1" in the client config file, so he is lost?

Adding a comment above like the following would be good?

[default_node]
# Target IP of the API. Defaults to localhost, and works both with IPv4 and IPv6 interfaces.
ip = "::1"
private_port = 33034
public_port = 33035

@sydhds
Copy link
Contributor

sydhds commented Jan 25, 2023

Is this a good idea to make ipv6 the default? I'm wondering if it can confuse user. Maybe documentation about supported ip address (ipv4 + ipv6) can help?

Oh, you mean a user that knows what 127.0.0.1 means but only sees ip = "::1" in the client config file, so he is lost?

Adding a comment above like the following would be good?

[default_node]
# Target IP of the API. Defaults to localhost, and works both with IPv4 and IPv6 interfaces.
ip = "::1"
private_port = 33034
public_port = 33035

I would even add something like:

... IPv4 (like 127.0.0.1) and IPv6 (like ::1) address.
I

@Leo-Besancon Leo-Besancon requested a review from sydhds January 26, 2023 14:03
@Leo-Besancon Leo-Besancon merged commit c4c155f into testnet_19 Jan 30, 2023
@sydhds sydhds deleted the 2607-base_configconfigtoml-need-ipv6-listen-on-port-33035 branch January 30, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants