Fix roll sell.

massa-execution-worker/src/context.rs

@@ -686,6 +686,9 @@ impl ExecutionContext {
     pub fn settle_slot(&mut self) -> ExecutionOutput {
         let slot = self.slot;
 
+        // execute the deferred credits coming from roll sells
+        self.execute_deferred_credits(&slot);
+
         // settle emitted async messages and reimburse the senders of deleted messages
         let ledger_changes = self.speculative_ledger.take();
         let deleted_messages = self
@@ -695,9 +698,6 @@ impl ExecutionContext {
             self.cancel_async_message(&msg);
         }
 
-        // execute the deferred credits coming from roll sells
-        self.execute_deferred_credits(&slot);
-
         // if the current slot is last in cycle check the production stats and act accordingly
         if self
             .slot

massa-execution-worker/src/tests/scenarios_mandatories.rs

@@ -834,6 +834,9 @@ pub fn roll_sell() {
     let keypair = KeyPair::from_str("S1JJeHiZv1C1zZN5GLFcbz6EXYiccmUPLkYuDFA3kayjxP39kFQ").unwrap();
     let address = Address::from_public_key(&keypair.get_public_key());
 
+    // get initial balance
+    let balance_initial = sample_state.read().ledger.get_balance(&address).unwrap();
+
     // get initial roll count
     let roll_count_initial = sample_state.read().pos_state.get_rolls_for(&address);
     let roll_sell_1 = 10;
@@ -915,6 +918,20 @@ pub fn roll_sell() {
         credits
     );
 
+    // Now check balance
+    let balances = controller.get_final_and_candidate_balance(&[address]);
+    let candidate_balance = balances.get(0).unwrap().1.unwrap();
+
+    assert_eq!(
+        candidate_balance,
+        exec_cfg
+            .roll_price
+            .checked_mul_u64(roll_sell_1 + roll_sell_2)
+            .unwrap()
+            .checked_add(balance_initial)
+            .unwrap()
+    );
+
     // stop the execution controller
     manager.stop();
 }