Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #3344

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Fix broken link #3344

merged 2 commits into from
Dec 23, 2022

Conversation

T1l3
Copy link
Contributor

@T1l3 T1l3 commented Dec 23, 2022

Can't find the blog post so I linked the youtube video

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Can't find the blog post so I linked the youtube video
README.md Outdated Show resolved Hide resolved
@T1l3 T1l3 requested a review from AurelienFT December 23, 2022 05:03
@AurelienFT
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Dec 23, 2022
3344: Fix broken link r=AurelienFT a=T1l3

Can't find the blog post so I linked the youtube video

* [ ] document all added functions
* [ ] try in sandbox /simulation/labnet
* [ ] unit tests on the added/changed features
  * [ ] make tests compile
  * [ ] make tests pass 
* [ ] add logs allowing easy debugging in case the changes caused problems
* [ ] if the API has changed, update the API specification

Co-authored-by: Tib <tib.pierre@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 23, 2022

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 23, 2022

Build succeeded:

  • build

@bors bors bot merged commit bb1e4ea into massalabs:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants