Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock compensation refactoring #3336

Merged
merged 7 commits into from
Dec 21, 2022
Merged

Clock compensation refactoring #3336

merged 7 commits into from
Dec 21, 2022

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Dec 19, 2022 •
edited
Loading

closes #3245

@Eitu33 Eitu33 marked this pull request as draft December 19, 2022 10:02
@Eitu33 Eitu33 marked this pull request as ready for review December 19, 2022 14:09
@AurelienFT AurelienFT self-requested a review December 19, 2022 14:10
@Eitu33 Eitu33 requested a review from sydhds December 20, 2022 08:59
sydhds
sydhds requested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@sydhds sydhds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce PR. A lot of code removed :)

massa-execution-worker/src/tests/scenarios_mandatories.rs Outdated Show resolved Hide resolved
massa-node/base_config/config.toml Outdated Show resolved Hide resolved
massa-client/src/tests/tools.rs Outdated Show resolved Hide resolved
massa-bootstrap/src/client.rs Show resolved Hide resolved
@Eitu33 Eitu33 merged commit 2656921 into testnet_18 Dec 21, 2022
@sydhds sydhds deleted the clock-comp-refacto branch December 22, 2022 16:45
@AurelienFT AurelienFT mentioned this pull request Dec 23, 2022
Merged
bors bot added a commit that referenced this pull request Jan 2, 2023
@bors @AurelienFT @Eitu33
Merge #3280
a0ecab8 
3280: Testnet 18 r=AurelienFT a=AurelienFT

PR for testnet 18. PRS in this testnet : 

- #3303 
- #3301 
- #3279 
- #3318 
- #3315
- #3332
- #3228 
- #3323 
- #3312 
- #3333 
- #3336 
- #3340 
- #3206 
- #3320 
- #3314 
- #3342 
- #3343 
- #3346
- #3339 
- #3351 
- #3349 
- #3354 
- #3348 
- #3347 

Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com>
Co-authored-by: Thomas Plisson <thomas.plisson@epitech.eu>
Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydhds sydhds sydhds requested changes

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eitu33 @sydhds @AurelienFT