Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup_test script + update unit tests wasm (testnet 17 tag) #3313

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Update setup_test script + update unit tests wasm (testnet 17 tag) #3313

merged 3 commits into from
Dec 8, 2022

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Dec 8, 2022

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested a review from AurelienFT December 8, 2022 09:54
@sydhds
Copy link
Contributor Author

sydhds commented Dec 8, 2022

Please wait until massa-unit-tests-src has been tag with TEST.17.0 :)

@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 8, 2022

Build succeeded:

@bors bors bot merged commit f7924c9 into main Dec 8, 2022
@sydhds sydhds deleted the feature/update_unit_tests_wasm_testnet_17 branch December 8, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @AurelienFT