Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by node id #3296

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Sort by node id #3296

merged 1 commit into from
Dec 2, 2022

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Dec 2, 2022 •
edited
Loading

fix #3282

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@aoudiamoncef aoudiamoncef marked this pull request as ready for review December 2, 2022 08:37
@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Build succeeded:

  • build

@bors bors bot merged commit a851f21 into main Dec 2, 2022
@AurelienFT AurelienFT deleted the hotfix/peers-sorting branch May 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep connected_nodes keys sorted in get_status
2 participants
@aoudiamoncef @AurelienFT