Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to regroup param in double quotes. #3187

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Oct 27, 2022

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Fix #2570 also avoid fetching the same command twice with two up arrows hit.

@AurelienFT AurelienFT requested a review from Eitu33 October 27, 2022 13:55
Copy link
Contributor

@Eitu33 Eitu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could've probably use nom for this hahaha but I'll agree to it 💀 💀

@AurelienFT AurelienFT merged commit 0462b5e into prepare_testnet_16 Oct 28, 2022
@AurelienFT AurelienFT mentioned this pull request Oct 28, 2022
7 tasks
bors bot added a commit that referenced this pull request Oct 31, 2022
3163: Prepare testnet 16 r=AurelienFT a=Eitu33

* [x] document all added functions
* [x] try in sandbox / simulation / labnet
* [x] unit tests on the added & changed features
  * [x] make tests compile
  * [x] make tests pass 
* [x] add logs allowing easy debugging in case the changes caused problems
* [x] if the API has changed, update the API specification

This PR contains the following ones : 
- #3147 
- #3165
- #3180 
- #3183 
- #3167
- #3185
- #3158
- #3186
- #3187
- #3164
- #3150 
- #3188 
- #3189
- #3190
- #3170 
- #3194 

Co-authored-by: Thomas Plisson <thomas.plisson@epitech.eu>
Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>
@AurelienFT AurelienFT deleted the improve_cli branch May 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants