Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send only required blocks to bootstrap #1866

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

damip
Copy link
Member

@damip damip commented Nov 27, 2021

No description provided.

@damip damip linked an issue Nov 27, 2021 that may be closed by this pull request
@damip
Copy link
Member Author

damip commented Nov 27, 2021

I used the opportunity to clean up a whole bunch of useless and performance-hindering mess that was introduced recently in the block graph bootstrap graph/block import/export system

Copy link
Contributor

@adrien-zinger adrien-zinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damip Look good to me, I asked myself about how many blocks we were speaking about while bootstrapping before? VS the number of blocks required.

@damip
Copy link
Member Author

damip commented Nov 29, 2021

@damip Look good to me, I asked myself about how many blocks we were speaking about while bootstrapping before? VS the number of blocks required.

initialy, about 100, after the optims about 1500

@damip
Copy link
Member Author

damip commented Nov 29, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 29, 2021

Build succeeded:

@bors bors bot merged commit 7d04ec5 into main Nov 29, 2021
@bors bors bot deleted the bootstrap_send_required_blocks_only branch November 29, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap: send only required final blocks
3 participants