Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emitter address and caller address are inverted in events #4409

Closed
AurelienFT opened this issue Sep 18, 2023 · 0 comments · Fixed by #4422
Closed

emitter address and caller address are inverted in events #4409

AurelienFT opened this issue Sep 18, 2023 · 0 comments · Fixed by #4422
Assignees
@modship

Comments

@AurelienFT
Copy link
Contributor

No description provided.

@AurelienFT AurelienFT changed the title emitter address and caller address are inverted emitter address and caller address are inverted in events Sep 18, 2023
@modship modship self-assigned this Sep 21, 2023
@AurelienFT AurelienFT mentioned this issue Sep 21, 2023
Merged
@modship modship linked a pull request Sep 21, 2023 that will close this issue
fix event filter #4422
Merged
8 tasks
bors bot added a commit that referenced this issue Oct 3, 2023
@bors @AurelienFT
Merge #4421
e6b90eb 
4421: Add tests and rename handler and data r=AurelienFT a=AurelienFT

## Important description

This PR improves readability of the `AsyncMessage` structure, fix potential panics.

### Details : 

- Fix potential panic behaviour : Denom value of 0 was accepted in deserialisation
- Fix problem function name in async message could be only u8::MAX size but the limit of length function is u16::MAX
- Unify data limits of async message that represent the parameters of the function call with the limits of parameters of a normal call. The values was differents.
- Wrong limit used for handler name in SetOrKeep serialisation
- Renamed handler -> function
- Renamed Data - > functions params
- Remove from bootstrap async pool variables unused
- Change excluded to included in  max size of trigger datastore key to match the behaviour of the ledger datastore key limit

### Follow up that needs to be done
In GRPC :
- Rename handler -> function
- Rename data -> function params

On a more general note, I think we should make a changelog for the mainnet so that we could add breaking changes (but useful to be done now otherwise it will be a bigger mess) like this change and #4409 for example. `@Leo-Besancon` and `@damip` I let you decide on that.

The `messages.rs` file now have 90% of line coverage and all min/max limit on serializer/deserializer are tested

Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
@AurelienFT AurelienFT mentioned this issue Oct 18, 2023
Draft
8 tasks
@Thykof Thykof mentioned this issue Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modship modship

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix event filter massalabs/massa
3 participants
@modship @Leo-Besancon @AurelienFT