Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet_info display nothing when passing --json CLI option #1825

Closed
yvan-sraka opened this issue Nov 18, 2021 · 5 comments · Fixed by #1862
Closed

wallet_info display nothing when passing --json CLI option #1825

yvan-sraka opened this issue Nov 18, 2021 · 5 comments · Fixed by #1862
Assignees

Comments

@yvan-sraka
Copy link
Contributor

Maybe something like that [{"addressxxxxxxxxxxxxxxxx": {private_key: "xxxxxxxxxxx", public_key: "xxxxxxxxxxx"}]

Originally posted by @AureliaDolo in #1789 (comment)

@AureliaDolo
Copy link
Contributor

Are there other commands that display nothing ?

@yvan-sraka
Copy link
Contributor Author

Every command that return an Ok(Box::new(())) in https://github.com/massalabs/massa/blob/main/massa-client/src/cmds.rs

@AureliaDolo
Copy link
Contributor

AureliaDolo commented Nov 19, 2021

Every command that return an Ok(Box::new(())) in https://github.com/massalabs/massa/blob/main/massa-client/src/cmds.rs

Ok so it would be usefull if node_testnet_rewards_program_ownership_proof wallet_generate_private_key wallet_add_private_keys also returned something

  • node_testnet_rewards_program_ownership_proof -> [String] // just the string that should be pasted in discord
  • wallet_generate_private_key -> [String] // created address
  • wallet_add_private_keys -> [String] // derived address

@damip
Copy link
Member

damip commented Nov 23, 2021

do we have wallet_remove_address ? if not, it should be added

@AureliaDolo
Copy link
Contributor

do we have wallet_remove_address ? if not, it should be added

#1124 was closed because that command was already implemented but without the confirmation check.

I did not include it in the previous list as anyway it returns nothing

bors bot added a commit that referenced this issue Nov 29, 2021
1857: Delete `rust-toolchain` file r=yvan-sraka a=yvan-sraka



1860: Ci/fix-bors-success-failed r=yvan-sraka a=yvan-sraka



1862: Resolve #1825: `wallet_info` display nothing when passing `--json` CLI option r=yvan-sraka a=yvan-sraka



Co-authored-by: Yvan Sraka <yvan@sraka.xyz>
@bors bors bot closed this as completed in 3318d4b Nov 29, 2021
@bors bors bot closed this as completed in #1862 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants