Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get end client command #1146

Closed
massa-bot opened this issue Nov 12, 2021 · 4 comments · Fixed by #1855
Closed

Add get end client command #1146

massa-bot opened this issue Nov 12, 2021 · 4 comments · Fixed by #1855
Assignees
Labels
enhancement New feature or request

Comments

@massa-bot
Copy link

In GitLab by @AureliaDolo

Add a get_end command to the client to get the end timestamp of that episode.

And maybe in a countdown form like : 3 days and 7h17 remaining in episode X

@massa-bot massa-bot added client enhancement New feature or request labels Nov 12, 2021
@massa-bot
Copy link
Author

In GitLab by @AureliaDolo

@damip @yvan-sraka @g-massa what do you think about that ?

@massa-bot
Copy link
Author

In GitLab by @yvan-sraka

Could be useful, not convinced by the naming, what about get_end_timestamp_of_episode?

@massa-bot
Copy link
Author

In GitLab by @damip

this is testnet-specific, I would vote for not polluting code with too many things that will have to be removed after the testnet ends

@massa-bot
Copy link
Author

In GitLab by @AureliaDolo

That's not a lot a work and it answers a common question

@AureliaDolo AureliaDolo linked a pull request Nov 25, 2021 that will close this issue
bors bot added a commit that referenced this issue Dec 2, 2021
1855: Fix #1146 added when episode ends client command. r=AureliaDolo a=AureliaDolo



Co-authored-by: Aurelia <adolo@massa.network>
@bors bors bot closed this as completed in b92f163 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants