Track down the error point.

massalabs · Feb 1, 2023 · 67d2921 · 67d2921
1 parent 1db6b2a
commit 67d2921
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/massa-execution-exports/src/test_exports/mock.rs b/massa-execution-exports/src/test_exports/mock.rs
@@ -214,9 +214,8 @@ impl ExecutionController for MockExecutionController {
         {
             println!("mock error {err}");
         }
-        response_rx
-            .recv_timeout(Duration::from_millis(100))
-            .unwrap()
+        dbg!("never seen this not err...");
+        dbg!(response_rx.recv_timeout(Duration::from_millis(100))).unwrap()
     }
 
     fn clone_box(&self) -> Box<dyn ExecutionController> {

diff --git a/massa-pool-worker/src/operation_pool.rs b/massa-pool-worker/src/operation_pool.rs
@@ -221,13 +221,17 @@ impl OperationPool {
 
             // check if the op was already executed
             // TODO batch this
+            dbg!(&slot);
             if self
                 .execution_controller
                 .unexecuted_ops_among(&vec![op_info.id].into_iter().collect(), slot.thread)
                 .is_empty()
             {
+                // this is never outputted
+                dbg!("continuing");
                 continue;
             }
+            dbg!(&slot);
 
             // check balance
             //TODO: It's a weird behaviour because if the address is created afterwards this operation will be executed

diff --git a/massa-pool-worker/src/tests/operation_pool_tests.rs b/massa-pool-worker/src/tests/operation_pool_tests.rs
@@ -126,10 +126,14 @@ fn test_pool() {
 
     // checks ops are the expected ones for thread 0 and 1 and various periods
     for thread in 0u8..pool_config.thread_count {
+        dbg!(thread);
         for period in 0u64..70 {
             let target_slot = Slot::new(period, thread);
             let max_count = 3;
+            // fails at a non-deterministic point in this double iteration.
+            // Furthest I saw it get was thread 8 in 0..32
             let (ids, storage) = pool.get_block_operations(&target_slot);
+
             assert!(ids
                 .iter()
                 .map(|id| (