Skip to content

Commit

Permalink
Fix fallback input for release action for real
Browse files Browse the repository at this point in the history
Turns out `'master'` probably worked all along as a fallback, the
problem is that I was using `'master '`, with a trailing space, which
was not a branch git managed to find for obvious reason, and since I
carried the error into the fully qualified reference... is still
didn't work.

And manual triggers didn't have the issue because the tag was
`required`, so I'd have to input the tag by hand every time, and the
fallback value would be bypassed.

- fix the fallback value
- remove the requirement on `tag`, such that it's possible to manually
  trigger the action in a default state
  • Loading branch information
masklinn committed Mar 3, 2025
1 parent 60b35ec commit 967a2bb
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/release-builtins.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:
tag:
description: "uap-core ref to release"
type: string
required: true
environment:
description: "environment to release for (testpypy or pypy)"
type: environment
Expand All @@ -30,7 +29,7 @@ jobs:
persist-credentials: false
- name: update core
env:
TAG: ${{ inputs.tag || 'origin/master '}}
TAG: ${{ inputs.tag || 'origin/master' }}
# needs to detach because we can update to a tag
run: git -C uap-core switch --detach "$TAG"
- name: Set up Python
Expand Down

0 comments on commit 967a2bb

Please sign in to comment.