-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use translation from default locale if provided locale is undefined
or null
#502
base: master
Are you sure you want to change the base?
Conversation
thanks @longdoan7421 for submitting this PR. Did you plan to also complete any other methods? |
Hi @mashpie, I'm gonna continue working on the plural method For the other methods, I don't see they have option to pass |
… or "null" when using method i18n.__n. Issue mashpie#501
Hi @mashpie, sorry for the delay. I added the fix for API |
Thanks @longdoan7421 - and sry for delay. LGTM! Hope to review closer and of week. |
Any updates on this? |
@longdoan7421 can you fix |
@EinfachHans I was not aware of |
I use it because it integrates with messageformat: https://github.com/mashpie/i18n-node#i18n__mf At the end of the day this patch should be applied to all functions i guess 🤔 |
… or "null" for method i18n.__mf. Issue mashpie#501
Hi @mashpie, I added a similar fix for method |
Close #501.
i18n.__
i18n.__n