Skip to content
This repository was archived by the owner on Aug 1, 2022. It is now read-only.

fix(Prometheus-client): Return error message when using invalid query #81

Merged
merged 50 commits into from
Jul 19, 2022

Conversation

Qinyouzeng
Copy link
Contributor

No description provided.

@Qinyouzeng Qinyouzeng requested review from doddgu and zhenlei520 July 6, 2022 03:57
@@ -9,7 +9,7 @@ internal static class CallerProviderExtensions
public static async Task<string> GetAsync(this ICallerProvider caller, string url, object data)
{
var request = new HttpRequestMessage(HttpMethod.Get, $"{url}?{data.ToUrlParam()}");
var response = await caller.SendAsync(request);
var response = await caller.SendAsync(request,autoThrowUserFriendlyException:false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Code

Copy link
Contributor

@zhenlei520 zhenlei520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenlei520 zhenlei520 merged commit 43415bc into main Jul 19, 2022
@zhenlei520 zhenlei520 deleted the fix/prometheus-invalid-query branch July 19, 2022 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants