Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iterators real iterators #77

Merged
merged 1 commit into from Dec 18, 2020
Merged

Make iterators real iterators #77

merged 1 commit into from Dec 18, 2020

Conversation

HazardyKnusperkeks
Copy link
Contributor

They were missing the iterator_category and thus could not be used with
some standard algorithms.

What does this change do?

Making table_iterator and array_iterator usable with standard algorithms and iterator functions.

Is it related to an exisiting bug report or feature request?

Pre-merge checklist

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 6 or higher
    • GCC 7 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

Copy link
Owner

@marzer marzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling this gap! Just need to move things around a little.

tests/user_feedback.cpp Outdated Show resolved Hide resolved
tests/user_feedback.cpp Outdated Show resolved Hide resolved
They were missing the iterator_category and thus could not be used with
some standard algorithms.
Copy link
Owner

@marzer marzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@marzer marzer merged commit 05f8b1f into marzer:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants